Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Migrate vue3-vite to ts strict mode #23375

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Build: Migrate vue3-vite to ts strict mode #23375

merged 3 commits into from
Jul 25, 2023

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Jul 8, 2023

Closes #

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@chakAs3 chakAs3 added the build Internal-facing build tooling & test updates label Jul 8, 2023
@chakAs3 chakAs3 mentioned this pull request Jul 8, 2023
Closed
@chakAs3 chakAs3 changed the title Build: Migrate vue3-vite to strict typescript mode Build: Migrate vue3-vite to ts strict mode Jul 8, 2023
kasperpeulen
kasperpeulen approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chakAs3 chakAs3 requested review from yannbf and JReinhold as code owners July 25, 2023 08:18
@chakAs3 chakAs3 removed request for yannbf and JReinhold July 25, 2023 08:20
@kasperpeulen kasperpeulen merged commit dcbf72a into next Jul 25, 2023
@kasperpeulen kasperpeulen deleted the chaks/strict-ts-vue3-vite branch July 25, 2023 10:50
This was referenced Jul 25, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees

@kasperpeulen kasperpeulen

Labels
build Internal-facing build tooling & test updates ci:normal typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chakAs3 @kasperpeulen @JReinhold